Business is booming for investors in college housing, who poured $22.9 billion into the industry last year. But for students, the picture is more fraught.